Drop dead eager requires from cider.nrepl#996
Merged
Conversation
`orchard.info` and `orchard.namespace` were pulled in eagerly for an Orchard cache warmup that has since been removed, leaving them unused. Eager requires here are particularly undesirable: this namespace exists to *defer* loading heavy middleware dependencies until first use, so loading Orchard at startup for nothing defeats the purpose. Also drop the unused `misc` alias on `nrepl.misc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orchard.infoandorchard.namespacewere required eagerly for an Orchard cache warmup that got removed a while back, so they're now dead. They're especially worth dropping here, sincecider.nreplexists to defer loading heavy middleware deps - eagerly pulling in Orchard at startup for nothing works against that. Also drops the unusedmiscalias.