cider-change-buffers-designation is broken with update

[johnbendi]

cider-change-buffers-designation is broken with my recent update. Please try it and check.

Also C-c M-c doesn't bother me with whether a connection existed, previously. I like it that way and it should just give me a new connection that I can run cider-change-buffers-designation on and get on with my work.

Regards.

[bbatsov]

Yeah, it seems it was broken a while back by some of @vspinu's changes (making the REPL buffer the connection buffer).

[bbatsov]

Problem fixed.

@vspinu We should remove nrepl-connection-buffer from the code as it seems to me it has little value (does it make sense to make a connection without a REPL buffer?) and it causes some confusion.

[vspinu]

@vspinu We should remove nrepl-connection-buffer from the code as it seems to me it has little value

It will make a lot of sense when nrepl-clinet.el is a separate package. I can imagine a lot of examples when a tool would not need a repl or any of the editing capabilities of Cider. For now it's indeed confusing and it should be better removed.

Two examples of non-REPL nREP clients of a particular interest to me are data analytic clojure front-end and interactive trading platform. There are other tools that would directly benefit from an interactive emacs front-end, like overtone or palete.