Skip to content

Conversation

@mallt
Copy link
Contributor

@mallt mallt commented Dec 16, 2018

This PR fixes the no comment syntax defined message when loading a buffer after running a failing test, by adding a save-excursion to make sure the loaded buffer does not lose focus.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • All code passes the linter (make lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

cider-eval.el Outdated
(remove-overlays nil nil 'cider-temporary t)
(cider--clear-compilation-highlights)
(cider--quit-error-window)
(save-excursion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it enough to wrap this just cider--quit-error-window for this? I also wonder if we shouldn't have the save-excursion in it instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, thanks! During testing it seemed the removal of the overlays also caused switching of the focus but I can't seem to reproduce that now... I will give it some further testing and update the PR.

@bbatsov bbatsov merged commit 8c00eca into clojure-emacs:master Dec 21, 2018
@bbatsov
Copy link
Member

bbatsov commented Dec 21, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants