Refactor the interactive evaluation API #816
Conversation
cider-client.el
Outdated
There was a problem hiding this comment.
This op those not support the ns param. See the reference.
There was a problem hiding this comment.
This op those not support the ns param. See the reference.
It does not but it return "ns" in the response and if it's not supplied
the response ns is either "user" or some other arbitrary (as far as I
can tell) ns.
Cider relies on returned ns for setting nrepl-buffer-ns. So this
actually fixes #814. Forgot to mention that.
I don't like nrepl-buffer-ns tracking as it's currently implemented
and if I understand correctly you are not found of it either. But for
time being let this be there.
There was a problem hiding this comment.
Ok, all that is true, but I have just discovered that we cannot keep the "ns" as an argument to :load-file op. It doesn't work on first evaluation status ("namespace-not-found" "error" "done"). So the nrepl-buffer-ns will stay "user" unless we remove its auto assignment in nrepl-dbind-response. In any case this will not cause any issues with interactive evaluation because nrepl-buffer-ns is no longer used for that.
|
Apart from my small remarks, the code looks good. |
|
I have addressed all your comments. Thanks. |
- There is now one API entry point - `cider-interactive-eval`. All other
commands are based on it.
- Simplify the code by removing unused or unnecessary API functions:
`cider-interactive-eval-print`, `cider-popup-eval-print-handler`,
`cider-popup-eval-print`, `cider-interactive-eval-to-repl`
- Rename `cider-interactive-eval-print-handler` -> `cider-eval-print-handler`.
- Bring all interactive eval functionality into one place and arrange
functions in a logical order.
- `buffer` argument to interactive eval handlers is optional
Refactor the interactive evaluation API
2 participants
Before continuing on #815 I couldn't stop myself from cleaning up the interactive eval API.
There is now one API entry point -
cider-interactive-eval. All other commands are based on it. I am removing a couple of unnecessary API functions. Entries likecider-interactive-eval-in-repladd naming redundancy with the corresponding handler. You can simply callcider-interactive-evalwitheval-in-replhandler and the code will be just as clear.Other changes:
eval functions. This patch completes the change.
cider-interactive-eval-print,cider-popup-eval-print-handler,cider-popup-eval-print,cider-interactive-eval-to-replcider-interactive-eval-print-handler->cider-eval-print-handler.functions in a logical order.
bufferargument to interactive eval handlers is optional