Skip to content

Conversation

@vspinu
Copy link
Contributor

@vspinu vspinu commented Sep 27, 2014

  • On errors in cider-read-and-eval don't jump to non-existent locations but create a buffer with relevant ns-form and evaled expression
  • Truly use cider-minibuffer-history in cider-read-from-minibuffer

- On errors in `cider-read-and-eval` don't jump to non-existent locations but
  create a buffer with relevant ns-form and evaled expression

- Truly use `cider-minibuffer-history` in `cider-read-from-minibuffer`
@bbatsov
Copy link
Member

bbatsov commented Sep 29, 2014

As this command is generally used to eval only one-liners, I don't quite the get point of the proposed change.

@vspinu
Copy link
Contributor Author

vspinu commented Sep 29, 2014

The point is twofold. First, rely on common cider-interactive-eval so that you don't have to maintain two different paradigms of evaluation. Second, if there is an error you are placed in a buffer with the code which you can modify and evaluate directly from that buffer, one-liner or not, it's more convenient to look and modify errors in a buffer than in the minibuffer.

The problem is that cider-eval-and-read must be changed to avoid jumping to non-existent error location in the current buffer. So, the alternative to the above is to use cider-eval as it was before.

bbatsov added a commit that referenced this pull request Nov 15, 2014
Use `*cider-read-eval*` buffer for `cider-read-and-eval` error locations
@bbatsov bbatsov merged commit c8f4e7c into clojure-emacs:master Nov 15, 2014
@vspinu vspinu deleted the read-eval branch August 1, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants