Add make lint and shared test-session helper#421
Merged
Conversation
Borrowing two small conveniences from cider-nrepl: - `make lint` chains kondo, cljfmt, and eastwood in one go; saves running them individually before pushing. - `refactor-nrepl.test-session` centralizes the in-process nREPL server + session setup that was duplicated across integration-style tests. resolve-missing-test and resolve-missing-caching-test now share it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrowing two small conveniences from cider-nrepl:
make lintchainskondo,cljfmt, andeastwoodin one go — saves running them individually before pushing.refactor-nrepl.test-sessioncentralizes the in-process nREPL server + session setup that was duplicated across integration-style tests.resolve-missing-testandresolve-missing-caching-testnow share it.(Dropped a planned CHANGELOG reformat from the original quick-wins list — turns out cider-nrepl's CHANGELOG is just as flat as ours, so there's nothing to copy there.)