[Fix #408] Don't wrap cljs auto-aliased namespaces in :clj reader conditional#423
Merged
[Fix #408] Don't wrap cljs auto-aliased namespaces in :clj reader conditional#423
Conversation
…ditional ClojureScript's analyzer auto-aliases requires of clojure.test, clojure.math, clojure.pprint and friends to their cljs.* counterparts, so a plain [clojure.X :as ...] is valid in both Clojure and ClojureScript. The previous hardcoded special case only handled clojure.test; extend it via a small allowlist so suggest-libspecs no longer offers #?(:clj [clojure.math :as math]) inside .cljc files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #408.
suggest-libspecswas wrappingclojure.mathin#?(:clj ...)inside.cljcfiles, even though ClojureScript auto-aliasesclojure.mathtocljs.math(and same forclojure.pprint,clojure.repl, etc.). The existing special case infiles->platformonly knew aboutclojure.test; I extended it via a small allowlist of paths that mirror cljs'saliasable-clj-ns?rule.lein do clean, test)make install-- takes a long time)