[#347] Add regression test for namespaces that set! *warn-on-reflection*#425
Merged
[#347] Add regression test for namespaces that set! *warn-on-reflection*#425
Conversation
The original report (refactor-nrepl 2.5.1, 2021) no longer reproduces against tools.analyzer.jvm 1.3.4 - building an AST for a namespace that sets *warn-on-reflection* (or *unchecked-math*) at the top level succeeds in both .clj and .cljc files. Pin that down with a regression test using two new fixtures so we catch any future analyzer/tooling update that breaks it again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original report (refactor-nrepl 2.5.1, 2021) was that building an AST for a namespace with
(set! *warn-on-reflection* true)at the top level threwCan't set!: *warn-on-reflection* from non-binding thread. I couldn't reproduce it against the currenttools.analyzer.jvm(1.3.4) - both.cljand.cljccases build cleanly.Adding two fixtures to
ns-ast-testso we catch any future analyzer/tooling update that re-breaks this. No production code change.Once this lands I'd close #347 as resolved-upstream.
lein do clean, test)make install-- takes a long time)