Refresh pods after test run. Include expectation lib into pod warmup.#11
Conversation
As a consequence the 1st test run happens right after the 1st pod is warmed up and subsequent test runs will happen in the next warmed up pod. It's also enough to setup the task cleanup action once, as seen at: https://github.com/adzerk-oss/boot-test/blob/master/src/adzerk/boot_test.clj#L88
| (finally | ||
| (doseq [f ~shutdown] | ||
| (f)))))] | ||
| (pods :refresh) |
There was a problem hiding this comment.
I'm also testing (future (pods :refresh)) here, to allow faster feedback, when used in combination with the speak task.
|
I'm going to merge this as-is and release a new version so we can try out your changes at World Singles as well. If you find |
Refresh pods after test run. Include `expectation` lib into pod warmup.
|
Testing this in a full pipeline at work uncovers a problem: your changes cause Expectations cleanup to happen after the pod has been cleaned up so it can trigger "Exception in thread "Thread-34" java.lang.NoClassDefFoundError: clojure/core$ns_interns$fn__5116" I'll see which one of the specific changes causes this and will push an updated release. |
|
I often saw that error with v1.0.5 too but my patch hasn't changed that behaviour. |
2 participants
As a consequence the 1st test run happens right after the 1st pod is
warmed up and subsequent test runs will happen in the next warmed up
pod.
It's also enough to setup the task cleanup action once, as seen at:
https://github.com/adzerk-oss/boot-test/blob/master/src/adzerk/boot_test.clj#L88