Skip to content

CLJS-3480: Browser REPL - (println "Expected:") breaks REPL #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swannodette merged 1 commit into from
May 26, 2026
+8 −4
Merged

CLJS-3480: Browser REPL - (println "Expected:") breaks REPL #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/cljs/clojure/browser/repl.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
(garray/clear print-queue))

(defn repl-print [data]
(.push print-queue (pr-str data))
(.push print-queue data)
(when @parent-connected?
(flush-print-queue! @xpc-connection)))

Expand Down
10 changes: 7 additions & 3 deletions src/main/clojure/cljs/repl/browser.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,13 @@
[{:keys [repl data order] :as _request-content} conn _]
(constrain-order order
(fn []
(binding [*out* (or (and repl (.get outs repl)) *out*)]
(print (edn/read-string data))
(.flush *out*))))
(try
(binding [*out* (or (and repl (.get outs repl)) *out*)]
(print data))
(catch Throwable t
(print t))
(finally
(.flush *out*)))))
(server/send-and-close conn 200 "ignore__"))

(defmethod handle-post :result
Expand Down
Loading