Update and change position for newsletter signup #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- take out link to MailChimp css - use bootstrap css for form and button - delete css comments
Member
|
I like how it looks! I'm not sure about calling it "newsletter" though unless someone takes charge of writing a regular newsletter |
Member
Author
|
Ok, we can name it however we want. Just wanted to find a name we don't have to translate ;) |
Member
Author
|
On the other hand people like it nowadays not to be spammed by a newsletter but receive information when it is important... |
Member
|
Yeah my intention with this list is to just use it to announce new workshops or related events. |
Member
Author
|
Then let's call it News? Or News Mailing List? |
Member
|
Yeah that sounds good |
Member
Author
Member
|
👍 |
Member
Author
|
I will merge both then? |
Member
|
Yes, please go ahead. Sorry I'm packing now and leaving in the morning, I'm not going to be doing much for ClojureBridge for a little while. |
Member
Author
|
Ok, will do! All the best for your trip!! |
Malwine
added a commit
that referenced
this pull request
Feb 4, 2016
…sition_for_newsletter_signup Update and change position for newsletter signup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the newsletter sign up to the top and updates some text.
⚠️ We have to test if the sign up still works.
⚠️ To be merged into PR #14
