Skip to content

Conversation

portovep
Copy link
Contributor

I think it would be nice that our deployment script does not depend on having Git installed and having authorisation to access the remote repo. It would allow to deploy the app to a server using commands like scp or curl and not only git clone.

@vise890
Copy link
Member

vise890 commented Jan 31, 2015

I agree and I like the idea. At that point why don't we keep this open, and continue on bringing the full build on the local dev machine.

What about having a :build lein task that replaces the deploy.sh script and pushes to the server via scp. We can store the credentials in profiles.clj (which is loaded already in project.clj by Leiningen) and.gitignore` it.

What do you think?

@portovep
Copy link
Contributor Author

Sounds good to me. I will put us in a position where we could even use SnapCI to automate the deployment of the latest build to our server every time we merge a pull request or push.

@vise890
Copy link
Member

vise890 commented Feb 1, 2015

Ok, so because we can't all push to your branch, instead of merging straight to master, i've merged into a topic branch in #14 . That way we can both clone the repo and propose changes. I've also opened #15 which is a replacement of this PR so that we can continue working on it.

Sounds good?

@vise890 vise890 closed this Feb 1, 2015
@portovep
Copy link
Contributor Author

portovep commented Feb 2, 2015

Good to me. I will try to find some time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants