Skip to content

reviewer.md の checkpoint warning 抑制と postmortem 誤検出防止#520

Merged
clonable-eden merged 3 commits intomainfrom
issue/519-reviewer-md-checkpoint-warning-postmorte
Mar 23, 2026
Merged

reviewer.md の checkpoint warning 抑制と postmortem 誤検出防止#520
clonable-eden merged 3 commits intomainfrom
issue/519-reviewer-md-checkpoint-warning-postmorte

Conversation

@clonable-eden
Copy link
Copy Markdown
Owner

closes #519

Summary

  • spawn.sh の checkpoint 存在チェックを AGENT_TYPE == worker の場合のみに限定。Reviewer は --resume で起動するが SUSPEND/checkpoint は Worker 専用概念のため、warning は不要
  • postmortem-patterns.md の「Missing checkpoint file」パターンに Exclusion を追加。Reviewer spawn 時の checkpoint 不在は正常動作として除外対象に

Test Plan

  • test-spawn-checkpoint-warning.sh — checkpoint warning が AGENT_TYPE で制御されることを検証
  • test-spawn-resume.sh — 既存の resume テストがパスすることを確認
  • test-spawn-reviewer.sh — 既存の reviewer テストがパスすることを確認

clonable-eden and others added 3 commits March 23, 2026 19:41
Verify spawn.sh only shows checkpoint warning for Worker resumes, not
Reviewer resumes. Checkpoints are a Worker-only concept written on SUSPEND.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…EEN)

Gate the checkpoint existence check behind AGENT_TYPE == worker so that
Reviewer spawns (which always use --resume) do not emit spurious warnings.
Checkpoints are only written on SUSPEND signal, a Worker-only concept.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…erns (REFACTOR)

Add Exclusion to the "Missing checkpoint file" pattern to prevent
false positives when analyzing Reviewer transcripts. The warning during
Reviewer spawn is expected behavior, not a cekernel defect.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Owner Author

@clonable-eden clonable-eden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: APPROVE ✅

Summary

Changes are well-scoped, correct, and aligned with the issue requirements.

Correctness

  • spawn.sh: Checkpoint check correctly gated behind AGENT_TYPE == "worker". Reviewers using --resume no longer emit spurious warnings. The warning is preserved for Workers where it remains meaningful.
  • postmortem-patterns.md: Exclusion is clear, well-placed under the "Missing checkpoint file" pattern, and accurately describes why the message should be excluded.

Conventions

  • Follows UNIX principles: Silence (suppress irrelevant noise), Repair (warning preserved where meaningful), Clarity (comments explain the rationale).
  • $((var + 1)) pattern used correctly in tests (bash 3.2 safe).
  • PR body includes closes #519. Conventional commit format followed.

Tests

  • Content-based tests on spawn.sh are a pragmatic approach given spawn.sh's heavy side effects (git worktree, claude --resume). Both tests verify the structural guard is in place.
  • CI: all 4 checks pass.

Scope

Focused exactly on the two files identified in the issue. No unrelated changes.

Note: Submitted as COMMENT because PR author and reviewer share the same GitHub identity. Verdict is APPROVE.

@clonable-eden clonable-eden merged commit 02d0270 into main Mar 23, 2026
4 checks passed
@clonable-eden clonable-eden deleted the issue/519-reviewer-md-checkpoint-warning-postmorte branch March 23, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reviewer.md の checkpoint warning 抑制と postmortem 誤検出防止

1 participant