reviewer.md の checkpoint warning 抑制と postmortem 誤検出防止#520
Merged
clonable-eden merged 3 commits intomainfrom Mar 23, 2026
Merged
reviewer.md の checkpoint warning 抑制と postmortem 誤検出防止#520clonable-eden merged 3 commits intomainfrom
clonable-eden merged 3 commits intomainfrom
Conversation
Verify spawn.sh only shows checkpoint warning for Worker resumes, not Reviewer resumes. Checkpoints are a Worker-only concept written on SUSPEND. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…EEN) Gate the checkpoint existence check behind AGENT_TYPE == worker so that Reviewer spawns (which always use --resume) do not emit spurious warnings. Checkpoints are only written on SUSPEND signal, a Worker-only concept. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…erns (REFACTOR) Add Exclusion to the "Missing checkpoint file" pattern to prevent false positives when analyzing Reviewer transcripts. The warning during Reviewer spawn is expected behavior, not a cekernel defect. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
clonable-eden
commented
Mar 23, 2026
Owner
Author
clonable-eden
left a comment
There was a problem hiding this comment.
Review: APPROVE ✅
Summary
Changes are well-scoped, correct, and aligned with the issue requirements.
Correctness
spawn.sh: Checkpoint check correctly gated behindAGENT_TYPE == "worker". Reviewers using--resumeno longer emit spurious warnings. The warning is preserved for Workers where it remains meaningful.postmortem-patterns.md: Exclusion is clear, well-placed under the "Missing checkpoint file" pattern, and accurately describes why the message should be excluded.
Conventions
- Follows UNIX principles: Silence (suppress irrelevant noise), Repair (warning preserved where meaningful), Clarity (comments explain the rationale).
$((var + 1))pattern used correctly in tests (bash 3.2 safe).- PR body includes
closes #519. Conventional commit format followed.
Tests
- Content-based tests on spawn.sh are a pragmatic approach given spawn.sh's heavy side effects (git worktree, claude --resume). Both tests verify the structural guard is in place.
- CI: all 4 checks pass.
Scope
Focused exactly on the two files identified in the issue. No unrelated changes.
Note: Submitted as COMMENT because PR author and reviewer share the same GitHub identity. Verdict is APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #519
Summary
spawn.shの checkpoint 存在チェックをAGENT_TYPE == workerの場合のみに限定。Reviewer は--resumeで起動するが SUSPEND/checkpoint は Worker 専用概念のため、warning は不要postmortem-patterns.mdの「Missing checkpoint file」パターンに Exclusion を追加。Reviewer spawn 時の checkpoint 不在は正常動作として除外対象にTest Plan
test-spawn-checkpoint-warning.sh— checkpoint warning が AGENT_TYPE で制御されることを検証test-spawn-resume.sh— 既存の resume テストがパスすることを確認test-spawn-reviewer.sh— 既存の reviewer テストがパスすることを確認