Support V2.8 features#141
Conversation
V2.8 hasn't launched yet but has been available on dev for a whlie
Summary of ChangesHello @cloneofghosts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates support for new features from version 2.8 of the Pirate Weather API, specifically focusing on the addition of day/night forecast data. It introduces a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the new day_night forecast feature from V2.8 of the Pirate Weather API. The changes include adding an include parameter to load_forecast to request this new data block, and a corresponding day_night() method on the Forecast object to access it. The documentation has also been updated. The changes look good and are consistent with the existing structure. I've only found a minor formatting issue in the README.md file.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Adds support for new V2.8 features available in the API namely the day/night forecast. V2.8 isn't yet available on the production API it has been available for test for a while now on the dev endpoint.
This hasn't been tested yet as the dev endpoint returns Internal Server Error at the moment and prod is on 2.7.11.