Skip to content

Support V2.8 features#141

Merged
cloneofghosts merged 2 commits into
masterfrom
2.8-features
Nov 15, 2025
Merged

Support V2.8 features#141
cloneofghosts merged 2 commits into
masterfrom
2.8-features

Conversation

@cloneofghosts
Copy link
Copy Markdown
Owner

Adds support for new V2.8 features available in the API namely the day/night forecast. V2.8 isn't yet available on the production API it has been available for test for a while now on the dev endpoint.

This hasn't been tested yet as the dev endpoint returns Internal Server Error at the moment and prod is on 2.7.11.

V2.8 hasn't launched yet but has been available on dev for a whlie
@cloneofghosts cloneofghosts added the enhancement New feature or request label Nov 15, 2025
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @cloneofghosts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for new features from version 2.8 of the Pirate Weather API, specifically focusing on the addition of day/night forecast data. It introduces a new include parameter for API requests and a corresponding method to access this new data block, ensuring the library can leverage the latest API capabilities. The changes also include necessary documentation updates and minor internal adjustments for robustness.

Highlights

  • New API Parameter: Introduced an optional include parameter to the load_forecast function, allowing users to request additional data blocks such as day_night_forecast from the API.
  • Day/Night Forecast Access: Added a new day_night() method to the Forecast object, providing a direct way to access the newly supported day/night weather data block.
  • Documentation Updates: Updated the README.md to reflect the new include parameter and the day_night() method, ensuring users are aware of the new functionalities.
  • Internal Data Handling: Modified the internal _pirateweather_data method to recognize and correctly fetch the day_night data block, and adjusted PirateWeatherDataBlock initialization for clarity regarding default values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the new day_night forecast feature from V2.8 of the Pirate Weather API. The changes include adding an include parameter to load_forecast to request this new data block, and a corresponding day_night() method on the Forecast object to access it. The documentation has also been updated. The changes look good and are consistent with the existing structure. I've only found a minor formatting issue in the README.md file.

Comment thread README.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@cloneofghosts cloneofghosts merged commit 8d7a69c into master Nov 15, 2025
7 checks passed
@cloneofghosts cloneofghosts deleted the 2.8-features branch November 15, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant