Skip to content

Fix tests for API version 2.8 updates#144

Merged
cloneofghosts merged 2 commits into
masterfrom
2.8-tests
Nov 23, 2025
Merged

Fix tests for API version 2.8 updates#144
cloneofghosts merged 2 commits into
masterfrom
2.8-tests

Conversation

@cloneofghosts
Copy link
Copy Markdown
Owner

@cloneofghosts cloneofghosts commented Nov 23, 2025

Fix #137

@cloneofghosts cloneofghosts added the enhancement New feature or request label Nov 23, 2025
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @cloneofghosts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the test suite for the python-pirateweather library to ensure compatibility and correct behavior with the latest changes introduced in version 2.8 of the Pirate Weather API. It includes adding a new test for a recently supported forecast inclusion and modifying existing tests to align with updated data structures from the API.

Highlights

  • Version Update: The package version in setup.py has been updated from 1.2.1 to 1.3.
  • New Test Case: A new test, test_day_night, has been added to verify the functionality of the day_night_forecast inclusion for the Pirate Weather API.
  • Updated Flag Assertions: The test_flags method has been updated to reflect changes in the Pirate Weather API's flags block, specifically adjusting the expected counts for sources and sourceTimes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tests to align with API version 2.8 updates. The package version is bumped, and test assertions are updated to match the new API responses. A new test for the day_night_forecast feature is also added. My review includes suggestions to improve the new test's readability and robustness.

Comment thread tests/test_pirateweather.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@cloneofghosts cloneofghosts merged commit 1bd6ff3 into master Nov 23, 2025
6 checks passed
@cloneofghosts cloneofghosts deleted the 2.8-tests branch November 23, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 2.8 enhancements

1 participant