Merged
Conversation
Owner
|
Running the build test now - if it passes (and I expect it should since this modifies very little of the existing code), I'll go ahead and merge it |
Owner
|
Build is failing due to lack of available servers on Packet. Trying again now |
Contributor
Author
|
That’s odd. Not sure why that would be the case. |
Owner
|
@man715 , yeah, nothing related to the code. Either Packet changed something with their API or something weird is going on |
Owner
|
Oh man, total clowntown on my part. I forgot CircleCI doesn't pass build secrets to PRs from forks. I'm temporarily enabling that for the sake of this build. Sorry about all the noise! |
Owner
|
Looks good! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides several scripts and a Vagrantfile to be used with Hyper-V. Installing the windows_ta Splunk application was throwing an authentication error. To fix that, the windows_ta application had to be moved to the VM then installed from there.