Merged
Conversation
buzinas
force-pushed
the
relax_mp3_detection_algorithm
branch
from
e48dd25 to
5a4dce8
Compare
wojcikstefan
approved these changes
Aug 17, 2018
Member
wojcikstefan
left a comment
wojcikstefan
left a comment
There was a problem hiding this comment.
LGTM, though I haven't tested it.
filevalidator.js
Outdated
| [0x49, 0x44, 0x33] | ||
| [0x49, 0x44, 0x33], | ||
| // Other MP3 files (FF Fx and FF Ex – they may cause false-positives) | ||
| // Headers got from https://www.garykessler.net/library/file_sigs.html |
| "version": "1.0.1", | ||
| "description": "File signature validation in JavaScript", | ||
| "main": "filevalidator.js", | ||
| "scripts": { |
Member
There was a problem hiding this comment.
Was this unnecessary? I don't see any tests added to the PR.
Member
There was a problem hiding this comment.
@wojcikstefan I think his point is "why was it necessary"
Contributor
Author
There was a problem hiding this comment.
This is added by npm init and it's unnecessary. It was just a clean up.
philfreo
reviewed
Aug 17, 2018
| // Other MP3 files (FF Fx and FF Ex – they may cause false-positives) | ||
| // Headers got from https://www.garykessler.net/library/file_sigs.html | ||
| [0xFF, 0xE0], [0xFF, 0xE1], [0xFF, 0xE2], [0xFF, 0xE3], [0xFF, 0xE4], | ||
| [0xFF, 0xE5], [0xFF, 0xE6], [0xFF, 0xE7], [0xFF, 0xE8], [0xFF, 0xE9], |
Member
There was a problem hiding this comment.
Isn't x in the external site referring to a hex number? So e.g. 0xEA - 0xEF are missing still ? Or am I thinking about this wrong?
Contributor
Author
There was a problem hiding this comment.
Hm, you're right, good point! Let me fix!
buzinas
force-pushed
the
relax_mp3_detection_algorithm
branch
from
0a20cb1 to
de6b891
Compare
philfreo
approved these changes
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/closeio/closeio/issues/8302.