PyMongo >= 4.2

[jkassemi]

Bumps PyMongo from 3.12.3 to 4.2 and addresses accompanying failures

[jkassemi]

After moving to MongoClient from MongoReplicaSetClient:

FAILED tests/document/test_instance.py::InstanceTest::test_can_save_if_not_included - ValueError: cannot encode native uuid.UUID with UuidRepresentation.UNSPECIFIED. UUIDs can be manually converted to b...
FAILED tests/document/test_instance.py::InstanceTest::test_do_not_save_unchanged_references - AttributeError: type object 'Collection' has no attribute 'update'
FAILED tests/document/test_json_serialisation.py::TestJson::test_json_complex - ValueError: cannot encode native uuid.UUID with UuidRepresentation.UNSPECIFIED. UUIDs can be manually converted to b...
FAILED tests/fields/test_fields.py::FieldTest::test_uuid_field_binary - ValueError: cannot encode native uuid.UUID with UuidRepresentation.UNSPECIFIED. UUIDs can be manually converted to b...
FAILED tests/queryset/test_queryset.py::QuerySetTest::test_json_complex - ValueError: cannot encode native uuid.UUID with UuidRepresentation.UNSPECIFIED. UUIDs can be manually converted to b...
FAILED tests/test_connection.py::ConnectionTest::test_connect - AttributeError: module 'pymongo' has no attribute 'mongo_client'
FAILED tests/test_connection.py::ConnectionTest::test_connect_uri - TypeError: 'Collection' object is not callable. If you meant to call the 'authenticate' method on a 'Database' objec...
FAILED tests/test_connection.py::ConnectionTest::test_register_connection - AttributeError: module 'pymongo' has no attribute 'mongo_client'

PyMongo 3.x encoded native UUIDs into a BSON Binary subtype 3 object. There's a transition under foot to the new subtype 4 object, in which some of the non-python clients that write UUIDs with varying byte orders will be standardized on the python client format.

Callers will need to explicitly pass a encoding options as PYTHON_LEGACY moving forward to ensure compatibility with all clients. PyMongo plans to use the STANDARD uuid representation in a future breaking change.

[jkassemi]

After the PYTHON_LEGACY updates:

FAILED tests/document/test_instance.py::InstanceTest::test_do_not_save_unchanged_references - AttributeError: type object 'Collection' has no attribute 'update'
FAILED tests/test_connection.py::ConnectionTest::test_connect - AttributeError: module 'pymongo' has no attribute 'mongo_client'
FAILED tests/test_connection.py::ConnectionTest::test_connect_uri - TypeError: 'Collection' object is not callable. If you meant to call the 'authenticate' method on a 'Database' ob...
FAILED tests/test_connection.py::ConnectionTest::test_register_connection - AttributeError: module 'pymongo' has no attribute 'mongo_client'

[jkassemi]

PyMongo 4.x doesn't export mongo_client and database, which results in some failures to import them from the module's init. Importing them directly addresses those failures.

We're now left with the following:

FAILED tests/document/test_instance.py::InstanceTest::test_do_not_save_unchanged_references - AttributeError: type object 'Collection' has no attribute 'update'
FAILED tests/test_connection.py::ConnectionTest::test_connect_uri - TypeError: 'Collection' object is not callable. If you meant to call the 'authenticate' method on a 'Database' ob...

[jkassemi]

Collection.update was removed, and we need to use Collection.update_one in its place. This just impacts a test, but once we've got that done:

FAILED tests/test_connection.py::ConnectionTest::test_connect_uri - TypeError: 'Collection' object is not callable. If you meant to call the 'authenticate' method on a 'Database' ob...

https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html#collection-update-is-removed

[wojcikstefan]

This is getting close!

I'd suggest still moving the most obvious and logically separate changes into their own PRs and merging / deploying them separately. This reduces the risk of each change and increases our ability to quickly identify what caused a potential issue. Slow is smooth and smooth is fast :)

[wojcikstefan]

@jkassemi we should probably update requirements.txt to point to PyMongo v4.2 now. So far, it still points to v3.12.3, which means that's what the CI tests are running with:

mongoengine/requirements.txt

Line 1 in a4cc37f

pymongo==3.12.3

Is there anything else that was part of this PR and that's still missing from the master branch?

[jkassemi]

@jkassemi we should probably update requirements.txt to point to PyMongo v4.2 now.

👍 #64

Is there anything else that was part of this PR and that's still missing from the master branch?

Let's get the upper bound <5.0 into setup.py's pymongo requirement - #65