Conversation
jkemp101
reviewed
Apr 19, 2021
| <th>Kwargs</th> | ||
| <td>{{ task_data.kwargs }}</td> | ||
| </tr> | ||
| {% if task.ts %} |
Member
There was a problem hiding this comment.
Would a ts of 0 be valid and therefore we would want to display that?
Contributor
Author
There was a problem hiding this comment.
If score was 0, it wouldn't pass this check anyway
https://github.com/closeio/tasktiger/blob/01085f30b0e39fe3445619e9983c886897989d32/tasktiger/task.py#L452
imo 0 would mean it was never scheduled - probably an invalid state? But not sure.
thomasst
approved these changes
Apr 20, 2021
Member
thomasst
left a comment
thomasst
left a comment
There was a problem hiding this comment.
Just make sure to change it back to a regular TaskTiger version when you release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked by @jkemp101 as extra for #14