Skip to content

Conversation

@ygalblum
Copy link
Contributor

Type of change

  • Refactor
  • New feature

Description

Implement getters related to k8s storage and snapshot
To allow mocking, implement a k8s connector interface
Update ocp-metadata to use the new connector

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • New Unit Tests

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 88.42105% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (cf5b399) to head (4d9c795).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
k8s-storage/storage_profile.go 70.00% 4 Missing and 2 partials ⚠️
k8s-storage/volume_snapshot_class.go 79.16% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   78.86%   80.74%   +1.87%     
==========================================
  Files           7       10       +3     
  Lines         388      483      +95     
==========================================
+ Hits          306      390      +84     
- Misses         64       71       +7     
- Partials       18       22       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit dcdbc64 into cloud-bulldozer:main Feb 14, 2025
6 checks passed
@ygalblum ygalblum deleted the ocp-storage branch February 14, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants