Skip to content

Install missing goimports on CI pipeline #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khos2ow merged 4 commits into from
Jul 29, 2019
Merged

Install missing goimports on CI pipeline #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
562e6e2
Install missing goimports on CI pipeline
khos2ow Jul 29, 2019
9b6f6b6
Show command
khos2ow Jul 29, 2019
5454efb
Do not use go modules
khos2ow Jul 29, 2019
9850c4c
Show 'tools' commands
khos2ow Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
key: repo-{{ .Environment.CIRCLE_SHA1 }}
- run:
name: Check formatting of all go files
command: make checkfmt
command: make goimports checkfmt

lint:
<<: *defaults
Expand Down
11 changes: 8 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,17 @@ authors: ## Generate Authors
changelog: ## Generate Changelog
git-chglog --config hack/chglog --output CHANGELOG.md

.PHONY: goimports
goimports: ## Install goimports
@ $(MAKE) --no-print-directory log-$@
GO111MODULE=off go get -u golang.org/x/tools/cmd/goimports

.PHONY: tools
tools: ## Install required tools
@ $(MAKE) --no-print-directory log-$@
@ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(shell go env GOPATH)/bin $(GOLANGCI_VERSION)
@ curl -sfL https://github.com/git-chglog/git-chglog/releases/download/$(GITCHGLOG_VERSION)/git-chglog_$(shell go env GOOS)_$(shell go env GOARCH) -o $(shell go env GOPATH)/bin/git-chglog && chmod +x $(shell go env GOPATH)/bin/git-chglog
@ cd /tmp && go get -v -u github.com/mitchellh/gox
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(shell go env GOPATH)/bin $(GOLANGCI_VERSION)
curl -sfL https://github.com/git-chglog/git-chglog/releases/download/$(GITCHGLOG_VERSION)/git-chglog_$(shell go env GOOS)_$(shell go env GOARCH) -o $(shell go env GOPATH)/bin/git-chglog && chmod +x $(shell go env GOPATH)/bin/git-chglog
GO111MODULE=off go get -u github.com/mitchellh/gox

####################################
## Self-Documenting Makefile Help ##
Expand Down