Skip to content

Disable colored output by default #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khos2ow merged 2 commits into from
Aug 5, 2019
Merged

Disable colored output by default #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e7c64
Disable colored output by default
khos2ow Aug 5, 2019
1abf600
Rename to 'colored'
khos2ow Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/cca/cca.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ func NewCommand() *cobra.Command {

cmd.PersistentFlags().StringVar(&flags.APIURL, "api-url", cmdutil.DefaultAPIURL, "API url cloud.ca resources")
cmd.PersistentFlags().StringVar(&flags.APIKey, "api-key", "", "API Key to access cloud.ca resources")
cmd.PersistentFlags().StringVar(&flags.OutputFormat, "output", cmdutil.DefaultOutputFormat, "output format "+output.FormatString())
cmd.PersistentFlags().BoolVar(new(bool), "nocolor", false, "Disable colored output")
cmd.PersistentFlags().StringVar(&flags.OutputFormat, "output-format", cmdutil.DefaultOutputFormat, "output format "+output.FormatStrings())
cmd.PersistentFlags().BoolVar(&flags.OutputColored, "output-colored", false, "Enable or disable colored output")
cmd.PersistentFlags().StringVar(&flags.LogLevel, "loglevel", cmdutil.DefaultLogLevel.String(), "log level "+logutil.LevelsString())

cmd.AddCommand(completion.NewCommand(flags))
Expand Down
1 change: 1 addition & 0 deletions pkg/cmdutil/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type GlobalFlags struct {
ColorOutput bool
EnvironmentID string
LogLevel string
OutputColored bool
OutputFormat string
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/output/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ func Has(format string) bool {
return false
}

// FormatString returns a string representing all output formats
// FormatStrings returns a string representing all output formats.
// this is useful for help text / flag info
func FormatString() string {
func FormatStrings() string {
var b strings.Builder
b.WriteString("[")
for i, format := range outputFormats {
Expand Down