Skip to content

added Pages documentation section#35

Merged
semicoloncharmedlife merged 3 commits intomainfrom
chore-pages-documentation
Nov 22, 2024
Merged

added Pages documentation section#35
semicoloncharmedlife merged 3 commits intomainfrom
chore-pages-documentation

Conversation

@semicoloncharmedlife
Copy link
Copy Markdown
Contributor

Includes Pages' documentation section

@sknep
Copy link
Copy Markdown
Contributor

sknep commented Nov 20, 2024

should this page exist in this PR/branch?

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/

i clicked the header link for "Pages" to get there, and i think it's the wrong URL. prob should land at

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/documentation/

however, the header links there don't work. Maybe check all the nav again locally and then on the build

@semicoloncharmedlife
Copy link
Copy Markdown
Contributor Author

should this page exist in this PR/branch?

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/

i clicked the header link for "Pages" to get there, and i think it's the wrong URL. prob should land at

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/documentation/

however, the header links there don't work. Maybe check all the nav again locally and then on the build

should this page exist in this PR/branch?

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/

i clicked the header link for "Pages" to get there, and i think it's the wrong URL. prob should land at

https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/documentation/

however, the header links there don't work. Maybe check all the nav again locally and then on the build

The home page is replaced now that this branch has been rebased on main. It would not have worked until then since home page, contact, etc. was part of a different PR. The only thing that isn't merged in this branch now is the knowledge base section... so none of that will work running this branch and you'll get a 404. Documents work for me locally.

@sknep
Copy link
Copy Markdown
Contributor

sknep commented Nov 21, 2024

ah, got it, thanks. I think the sidebar links aren't quite right, because on the preview branch they 404 at
https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/pages/documentation/why-use-pages/ instead of arriving at
https://federalist-f689d682-d20c-4d0b-af7b-c1a42fcd49f5.sites.pages.cloud.gov/preview/cloud-gov/site/chore-pages-documentation/pages/documentation/why-use-pages/

they expect the root of the site to also be the root of the domain. Relative links instead? I realize they'd work on prod as-is but I'd want our preview builds to work too.

@semicoloncharmedlife
Copy link
Copy Markdown
Contributor Author

preview

I think I misunderstood your original comment... let me dig in. Might have questions.

@semicoloncharmedlife
Copy link
Copy Markdown
Contributor Author

Details

Good to go now. I definitely misunderstood the first go around.

Copy link
Copy Markdown
Contributor

@sknep sknep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@semicoloncharmedlife semicoloncharmedlife merged commit adf6b28 into main Nov 22, 2024
@Ephraim-G Ephraim-G deleted the chore-pages-documentation branch February 18, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants