Conversation
This was referenced Mar 16, 2026
Tsconfig alias break NestJS build because it doesn't care about the dist, it looks at the TypeScript sources directly. Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> *** Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
shikanime
changed the title
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (71.00% Estimated after merge)
StephaneTrebel
approved these changes
Mar 17, 2026
Collaborator
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
Ah je me disais aussi que c'était bizarre, haha.
J'ai jamais pu blairer les @ de toute façon, c'est trop facile d'aller un truc en dehors de ton module et que ça passe inaperçu. Vive les "../../../../.." explicites !
LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tsconfig alias break NestJS build because it doesn't care about the dist, it looks at the TypeScript sources directly.
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Stack created with Sapling. Best reviewed with ReviewStack.