fix: 🐛 ignore proxy in kaniko args if not in dsc#437
Merged
this-is-tobi merged 1 commit intodevelopfrom Feb 18, 2025
Merged
Conversation
this-is-tobi
requested review from
ArnaudTA,
Falltrades,
cmon33 and
mathieulaude
this-is-tobi
force-pushed
the
fix/extra-kaniko-args-proxy
branch
from
2d6b9bd to
63b929f
Compare
mathieulaude
approved these changes
Feb 18, 2025
Falltrades
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quel est le comportement actuel ?
La tâche ansible échoue si
dsc.harbor.proxyCachen'est pas déclarée.Quel est le nouveau comportement ?
La tâche ansible ignore
extra_kaniko_argssidsc.harbor.proxyCachen'est pas déclarée.Cette PR introduit-elle un breaking change ?
Non.
Autres informations