Skip to content

fix: handle bot join messages properly to get conversation id and name #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

fix: handle bot join messages properly to get conversation id and name #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nc_py_api/talk_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,17 @@ def conversation_token(self) -> str:

It can be used to react or reply to the given message.
"""
# bot join
if self.message_type == "Join":
return self._raw_data["object"]["id"]
return self._raw_data["target"]["id"]

@property
def conversation_name(self) -> str:
"""The name of the conversation in which the message was posted."""
# bot join
if self.message_type == "Join":
return self._raw_data["object"]["name"]
return self._raw_data["target"]["name"]

def __repr__(self):
Expand Down