Add extra col to represent no. of ops #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewbranca
reviewed
Sep 9, 2019
src/basho_bench_stats_writer_csv.erl
Outdated
| [Elapsed, | ||
| Window, | ||
| Units, | ||
| Operations, |
There was a problem hiding this comment.
You're adding another parameter to the io_lib:format call above but not to the format string. You'll want to add another ~w to the format string a few lines above.
ManwithaYarradoddi
force-pushed
the
107-add-ops-col-view-query
branch
8 times, most recently
from
299a642 to
68990e3
Compare
chewbranca
suggested changes
Sep 17, 2019
src/basho_bench_stats.erl
Outdated
| folsom_metrics:notify_existing_metric({overall_units, Op}, {inc, Units}, counter), | ||
| folsom_metrics:notify_existing_metric({units, Op}, {inc, Units}, counter) | ||
| folsom_metrics:notify_existing_metric({units, Op}, {inc, Units}, counter), | ||
| folsom_metrics:notify_existing_metric({overall_opz, Op}, {inc, 1}, counter), |
There was a problem hiding this comment.
Could you change opz to ops please? Basically use s instead of z.
ManwithaYarradoddi
force-pushed
the
107-add-ops-col-view-query
branch
from
8f6bdc8 to
730ba67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case: https://github.ibm.com/cloudant/fdb-acceptance/issues/107