This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Add partition Index count to db info response.#478
Merged
Conversation
ricellis
reviewed
Mar 25, 2019
| */ | ||
| public class PartitionInfo { | ||
|
|
||
| public static class Indexes { |
Member
There was a problem hiding this comment.
I think this belongs in DbInfo rather than PartitionInfo
Contributor
Author
There was a problem hiding this comment.
Ah, yes. I updated the wrong model here. Copied/pasted the new defs over to DbInfo.
smithsz
force-pushed
the
add-partition-index-meta
branch
from
d157ce5 to
8eb98b5
Compare
smithsz
force-pushed
the
add-partition-index-meta
branch
from
8eb98b5 to
fa25318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
This change adds the following fields to the db info response object for a partitioned database:
See https://github.com/cloudant/showroom/pull/233.
Approach
Add properties to the
PartitionInfoclass allowing the additional fields to be correctly deserialized.Schema & API Changes
Includes new getters on the
PartitionInfoclass (non-breaking).Security and Privacy
No change.
Testing
Includes additional mock unit tests.
Monitoring and Logging
No change.