This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Upgrade optional OkHttp dependency to version 3.12.2#485
Merged
Conversation
ricellis
approved these changes
May 29, 2019
Member
ricellis
left a comment
ricellis
left a comment
There was a problem hiding this comment.
+1
Just need to update that copyright.
|
|
||
| @Override | ||
| public Request authenticate(Route route, Response response) throws IOException { | ||
| if (route.proxy() != null) { |
Member
There was a problem hiding this comment.
This file needs a copyright update.
- Fixed FindBugs error by removing conditional block that checks if route.proxy is null
emlaver
force-pushed
the
upgrade-okhttp3-3.12.2
branch
from
8132ff0 to
179fed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
Upgrade optional OkHttp dependency to version 3.12.2
Approach
build.gradleSchema & API Changes
Security and Privacy
Testing
Monitoring and Logging