This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Multiview request changes to support Couch3#502
Merged
Conversation
98725f7 to
89f4798
Compare
James1912
approved these changes
Feb 18, 2020
POST directly to the view was deprecated in CouchDB 2.2 and is now removed in Couch3. Try POST to /queries first and if that fails, fallback to POST to the view.
89f4798 to
2294284
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
Updated view multi-query to work with CouchDB 3
For PRs without an associated issue and/or test/build issues
1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
Run
com.cloudant.tests.ViewsTest#multiRequestagainst CouchDB 3.2. What you expected to happen
Test to pass.
3. What actually happened
Test fails because POST to
{db}/_design/{ddoc}/_view/{viewname}withquerieswas deprecated since CouchDB 2.2 and is removed in CouchDB 3.Approach
Replace
POSTof{ "queries": [...]}body to{db}/_design/{ddoc}/_view/{viewname}withPOSTto{db}/_design/{ddoc}/_view/{viewname}/queries.On
badmatchfailure fallback to originalPOSTto maintain compatibility with CouchDB versions < 2.2.Schema & API Changes
Security and Privacy
Testing
Monitoring and Logging