Type of sinceSeq can be also a String besides an Integer

[mojito317]

Checklist

• Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
• Added tests for code changes or test/build only changes
• Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
• Completed the PR template below:

Description

Fixes #526

Approach

seqs could be Integers in CouchDB 1.x and Strings in 2.x, so I changed all the places where they remained Integers to JsonElement. With this, both Integer and String can be used.

Security and Privacy

• No change

Testing

• This behavior can be tested with ITs well, so I just extended ITs with a plus .sinceSeq(...) call which is going to use a seq from a {source_db}/_changes request.

Monitoring and Logging

• No change

[ricellis]

Nearly there, as discussed offline I think the seq things should preferably be in their own tests.
Otherwise 2 other things:

• don't change the existing API in the ReplicatorDocument model class
• changes entry

[ricellis]

To avoid breaking compatibility with anyone using this still with e.g. Couch 1.x we should not change this API.
I suggest reverting this and adding:
String getSinceSeqString() - which can output the JsonElement string (for both string and number seq types), the existing int method can be modified to check if the JsonElement is a number primitive and return the int if it is and throw (I guess an IllegalStateException) if it isn't.

[mojito317]

Fixed in 103eb3b and 0c4e3c8

[mojito317]

Nearly there, as discussed offline I think the seq things should preferably be in their own tests.

Done in 79abd33. Lmk if you would like to see more.

don't change the existing API in the ReplicatorDocument model class

Done in 103eb3b and 0c4e3c8.

• changes entry

Done in 64770f4.

[ricellis]

+1 just a couple nits

[mojito317]

+1 just a couple nits

Thanks for the thorough review! I fixed the nits in f3018dd.

[emlaver]

Looks good! We should consider adding a negative test to assert that an error message is thrown when passing in an unexpected type.

[mojito317]

We should consider adding a negative test to assert that an error message is thrown when passing in an unexpected type.

An unexpected sinceSeq (e.g. a "true" or a "asd") will cause a crashing state in the replication and the replication will fail and timeout eventually in the waitForReplicatorToReachStatus method:

java-cloudant/cloudant-client/src/test/java/com/cloudant/tests/util/Utils.java

Line 142 in 2c53b88

throw new TimeoutException("Timed out waiting for replication to complete");

Meanwhile, the replication document will disappear from the _replicator database.

Other types cannot be added, because compilation would fail.

[mojito317]

Thanks for the reviews @ricellis and @emlaver! I'm about to merge this!