This repository was archived by the owner on Mar 11, 2022. It is now read-only.
Add validation for doc ID and attachment names#529
Merged
Conversation
mojito317
approved these changes
Aug 26, 2021
vmatyus
approved these changes
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
Add validation for doc ID and attachment names
1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
Use an invalid document ID or attachment name.
2. What you expected to happen
The request to fail.
3. What actually happened
The request is passed to the server.
Approach
Add validation to functions that access document IDs or attachments to prevent clash with system paths.
Schema & API Changes
IllegalArgumentExceptionis thrown.Security and Privacy
Testing
Monitoring and Logging