Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Conversation

@smithsz
Copy link
Contributor

@smithsz smithsz commented Nov 19, 2018

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Ensure that Nano always returns a server object.

Approach

Add parseUrl: false option when instantiating Nano client.

Schema & API Changes

No change.

Security and Privacy

No change.

Testing

Covered in existing test suite.

Monitoring and Logging

No change.

Ensure that Nano always returns a server object.
@ricellis ricellis added this to the 3.0.0 milestone Nov 19, 2018
Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smithsz smithsz merged commit a6ef109 into master Nov 20, 2018
@smithsz smithsz deleted the set-parse-url-false branch November 20, 2018 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants