Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Conversation

@vmatyus
Copy link
Contributor

@vmatyus vmatyus commented Jan 15, 2021

Checklist

  • Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1
  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md|CHANGELOG.md) or test/build only changes
  • Completed the PR template below:

Description

Add migration guide from nodejs-cloudant to new beta cloudant-node-sdk library.
Guide includes a reference mapping table that links nodejs-cloudant to cloudant-node-sdk API operation documentation link.

Approach

Schema & API Changes

Security and Privacy

Testing

Monitoring and Logging

@vmatyus vmatyus self-assigned this Jan 15, 2021
Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@vmatyus vmatyus requested a review from emlaver January 18, 2021 12:59
Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some final comments

@vmatyus vmatyus requested review from bessbd and emlaver January 19, 2021 07:56
Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vmatyus
Copy link
Contributor Author

vmatyus commented Jan 20, 2021

Thank you for reviewing @emlaver and @bessbd ! I am about to merge this.

@vmatyus vmatyus merged commit 9817fdf into master Jan 20, 2021
@vmatyus vmatyus deleted the 183-nodejs-migration-guide branch January 20, 2021 11:51
@ricellis ricellis added this to the 4.3.1 milestone May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants