Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Conversation

@smithsz
Copy link
Contributor

@smithsz smithsz commented Aug 4, 2017

Thanks for your hard work, please ensure all items are complete before opening.

What

Fix client construction in cloudant_bluemix context manager.

How

Change cloudant_user and auth_token to positional arguments.

Testing

Includes additional unit test.

Issues

Fixes #311.

Change `cloudant_user` and `auth_token` to positional arguments.
Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@smithsz smithsz merged commit bcafb0d into master Aug 7, 2017
@smithsz smithsz deleted the 311-fix-cloudant-bluemix-client branch August 7, 2017 14:05
@ricellis ricellis modified the milestone: 2.6.0 Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants