-
Notifications
You must be signed in to change notification settings - Fork 55
Allow query parameters to be passed to custom changes filters #405
Conversation
d5da3c3 to
8dd861a
Compare
| self.assertSetEqual(set([x['id'] for x in changes]), expected) | ||
| self.assertTrue(str(feed.last_seq).startswith('100')) | ||
|
|
||
| def test_invalid_argument(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is no longer valid as passing foo='bar' is now accepted under ANY_ARG: ANY_TYPE.
ricellis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but please add the missing copyright update
| """ | ||
|
|
||
| import json | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a copyright update
8dd861a to
03385dc
Compare
|
@smithsz There's a couple cases that cause a CloudantArgumentError We should probably only allow |
|
I think we should serialise How about making |
fb490ca to
2c983e6
Compare
2c983e6 to
c74b7d8
Compare
emlaver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
Allow arbitrary query parameters to be passed to custom changes filters.
Fixes #402.
Approach
Add new
ANY_ARGandANY_TYPEto list of valid changes arguments:Schema & API Changes
No change.
Security and Privacy
No change.
Testing
Includes additional unit test.
Monitoring and Logging
No change.