Attempt to prevent out of order updates to jobs#657
Merged
gabriel-samfira merged 1 commit intocloudbase:mainfrom Mar 5, 2026
Merged
Conversation
Github webhooks (and probably any webhoks for that matter) are not guaranteed to be sent in order. As such, we may get a webhook notifying us of a job that is in_progress, and after that another webhook notifying us that the same job is now queued. This breaks state. The consequences of that is that we may get orphaned queued jobs that never get serviced. GARM does try to clean them up after a while, but we shouuld still prevent that scenario from happening. This change validates that a reverse transition does not happen. If we get a hook that it is in_progress, any subsequent update that tries to transition that job to queued, will fail. Same for any other transition that goes in reverse. Forward transitions are allowed. Even if we see a job as "completed" the first time we see it. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github webhooks (and probably any webhoks for that matter) are not guaranteed to be sent in order. As such, we may get a webhook notifying us of a job that is in_progress, and after that another webhook notifying us that the same job is now queued.
This breaks state. The consequences of that is that we may get orphaned queued jobs that never get serviced. GARM does try to clean them up after a while, but we shouuld still prevent that scenario from happening.
This change validates that a reverse transition does not happen. If we get a hook that it is in_progress, any subsequent update that tries to transition that job to queued, will fail. Same for any other transition that goes in reverse.
Forward transitions are allowed. Even if we see a job as "completed" the first time we see it.