scaleset: reap timed-out runners stuck in failed status#813
Merged
gabriel-samfira merged 1 commit intoJul 7, 2026
Merged
Conversation
reapTimedOutRunners only considered runners in pending/installing RunnerStatus as eligible for reaping. A runner whose agent reports a failure (RunnerStatus set to failed via AddInstanceStatusMessage) was never pending/installing again, and would never register as idle/active in github either, so it was permanently excluded from this check and leaked forever (instance never transitioned to pending_delete). Allow RunnerFailed through the same eligibility check. Downstream logic still requires the runner be missing from github or reported offline there before reaping, unchanged.
gabriel-samfira
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reapTimedOutRunnersonly considered runners inpending/installingRunnerStatusas eligible for reaping. A runner whose agent reports a failure (RunnerStatusset tofailedviaAddInstanceStatusMessage) was neverpending/installingagain, and would never register as idle/active in GitHub either, so it was permanently excluded from this check and leaked forever (the instance never transitioned topending_delete).This change allows
RunnerFailedthrough the same eligibility check. Downstream logic still requires the runner be missing from GitHub or reported offline there before reaping, unchanged.