Skip to content

Add optimize test command#46

Merged
ninjinkun merged 8 commits intomainfrom
optimize-test
Dec 10, 2020
Merged

Add optimize test command#46
ninjinkun merged 8 commits intomainfrom
optimize-test

Conversation

@ninjinkun
Copy link
Contributor

@ninjinkun ninjinkun commented Dec 1, 2020

Add launchable optimize test command. This PR should merge after #52.

How to use

$ LAUNCHABLE_TEST_SESSION=$(launchable record session --name 123)             
$ rails test $(launchable optimize test $(find test -regex .*_test.rb | tr "\n" " ") --name 123 --session $LAUNCHABLE_TEST_SESSION)

@ninjinkun ninjinkun changed the title Sketch optimize test command Add optimize test command Dec 9, 2020
@ninjinkun ninjinkun requested a review from shuheiktgw December 9, 2020 14:40
@ninjinkun
Copy link
Contributor Author

ninjinkun commented Dec 9, 2020

I haven't succeeded in this run yet because my local API caused 500. I'll try it again tomorrow.

@shuheiktgw
Copy link
Contributor

shuheiktgw commented Dec 9, 2020

@ninjinkun Did you hit the subsetting endpoint locally then it returned 500? I think I know why that happened so I'm happy to explain it to you if you need 👍

@ninjinkun ninjinkun marked this pull request as ready for review December 10, 2020 02:58
@ninjinkun
Copy link
Contributor Author

@shuheiktgw I succeeded to run it! Please review this PR.

Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ninjinkun ninjinkun merged commit 80bde7c into main Dec 10, 2020
@ninjinkun ninjinkun deleted the optimize-test branch December 10, 2020 05:14
gitbook-com bot pushed a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants