Skip to content

V3 accept grant#1

Merged
harmeetsingh-work merged 7 commits intocloudblocks:v3from
SteefB:v3-accept-grant
Aug 17, 2018
Merged

V3 accept grant#1
harmeetsingh-work merged 7 commits intocloudblocks:v3from
SteefB:v3-accept-grant

Conversation

@SteefB
Copy link
Copy Markdown

@SteefB SteefB commented Aug 1, 2018

No description provided.

Steef Burghouts added 7 commits March 27, 2018 08:48
…eeded for smart home sensors like the thermostat. Removed The SmartHomeDirectiveHandler, this should be moved in the project using this library. This library will solely provide models and request and response serialization.
…payload V3. Added Cookie property to endpoint. Added thermostat controller to namespaces.
@@ -0,0 +1,5 @@
package uk.co.gdickinson.smarthome.lambda.models;

public class Cookie {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of this class?

@Override
public int hashCode() {
final int prime = 31;
int result = 1;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use: Objects.hash(scale, value);


@Override
public MessageName getMessageName() {
// TODO Auto-generated method stub
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

@@ -113,7 +153,10 @@ public enum MessageName {
RETRIEVE_CAMERA_STREAM_URI_REQUEST(RetrieveCameraStreamUriRequest.class),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GET_TEMPERATURE_READING_REQUEST is never used

DISCOVER_APPLIANCES_RESPONSE(DiscoverAppliancesResponse.class),

@SerializedName("Response")
RESPONSE(Object.class),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESPONSE is never used

@harmeetsingh-work harmeetsingh-work merged commit 15594b3 into cloudblocks:v3 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants