LITE-19830 add extra metadata to logging extras #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
d3rky,
gab832,
jazz-jack,
marcserrat,
maxipavlovic,
mtvarkovsky,
net-free and
win0err
marcserrat
approved these changes
Aug 12, 2021
ghost
force-pushed
the
LITE-19830-add-extra-metadata-to-logs
branch
from
800f7ce to
a47effe
Compare
marcserrat
reviewed
Aug 12, 2021
connect/eaas/dataclasses.py
Outdated
| return dataclasses.asdict(self) | ||
|
|
||
| @classmethod | ||
| def from_json(cls, data): |
Contributor
There was a problem hiding this comment.
as we discussed, better from_dict and to_dict
ghost
force-pushed
the
LITE-19830-add-extra-metadata-to-logs
branch
from
a47effe to
687b1e1
Compare
d3rky
suggested changes
Aug 12, 2021
connect/eaas/dataclasses.py
Outdated
| return dataclasses.asdict(self) | ||
|
|
||
| @classmethod | ||
| def from_dict(cls, data): |
There was a problem hiding this comment.
Honestly for me dataclasses are something about the type and structure. That's why I don't think it is needed for some methods here. Especially if you need to copy it across all dataclasses. Why not to use existing dataclasses.asdict() and implement one like fromdict(cls, data)?
connect/eaas/manager.py
Outdated
| Wait for a background task to be completed and than uild the task result message. | ||
| """ | ||
| result_message = TaskPayload(**task_data.to_json()) | ||
| result_message = TaskPayload(**task_data.to_dict()) |
There was a problem hiding this comment.
Not sure, but looks like for copying the instances there is a specific method - link
| pass | ||
|
|
||
| def get_client(self): | ||
| def get_client(self, task_id): |
There was a problem hiding this comment.
Looks like here you didn't change comment for the function
ghost
force-pushed
the
LITE-19830-add-extra-metadata-to-logs
branch
from
687b1e1 to
638e2c9
Compare
marcserrat
approved these changes
Aug 13, 2021
d3rky
approved these changes
Aug 13, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra metadata: