Config singleton has to be accessed as Config.get_instance() #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 82.45% 82.59% +0.14%
==========================================
Files 23 23
Lines 473 477 +4
==========================================
+ Hits 390 394 +4
Misses 83 83
Continue to review full report at Codecov.
|
README.md
Outdated
| # set logger level / default level ERROR | ||
| logger.setLevel("DEBUG") | ||
|
|
||
| # If we remove this line, it is done implicitly |
There was a problem hiding this comment.
For example - better to do not bloat code with some defaults (logger, config, etc) - less code -> simpler to understand
There was a problem hiding this comment.
You want me to remove those two lines then? The good thing of having them there is that they serve as indication on how to set logger level and how to explicitly initialize (maybe with a different file name).
There was a problem hiding this comment.
Or maybe remove them from the README to make it as simple as possible, but leave it on example.py?
There was a problem hiding this comment.
remove Config and debug
3 participants
This one should not cause much trouble :)