Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

A Tier contains a contact_info field which is deserialized as a dictionary. Would it make more sense to deserialize it into its own model?

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #18 into master will increase coverage by 1.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   82.59%   83.75%   +1.15%     
==========================================
  Files          23       24       +1     
  Lines         477      511      +34     
==========================================
+ Hits          394      428      +34     
  Misses         83       83
Impacted Files Coverage Δ
connect/models/tiers.py 100% <100%> (ø) ⬆️
connect/models/contact.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23da37f...e830119. Read the comment docs.

@JaviCerveraIngram
Copy link
Collaborator Author

BTW, I have assumed that the properties of these models have not changed since R14, and I have taken the same properties that the PHP SDK uses. Please verify that these are correct for R15 (I have to double check, but I think the properties of some of the other models were not the same in the Python SDK as in the PHP SDK, which I assumed was due to changes in R15?).

@vgrebenschikov vgrebenschikov merged commit 03cd3e4 into cloudblue:master Mar 11, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the contactinfo branch March 11, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants