-
Notifications
You must be signed in to change notification settings - Fork 12
get list #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get list #30
Conversation
…ist respectively. get_list now accepts optional filters (get_filters is used if none provided).
connect/resource/base.py
Outdated
| filters[key] = val | ||
| return filters | ||
|
|
||
| def get_list(self, filters=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not list()
req.list(filters) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_list() sounds a bit ugly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it right now. I'll also rename "get_filters" to just "filters" using the same logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds fine for me
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 93.79% 93.77% -0.02%
==========================================
Files 28 28
Lines 1096 1093 -3
==========================================
- Hits 1028 1025 -3
Misses 68 68
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 93.79% 93.77% -0.02%
==========================================
Files 28 28
Lines 1096 1093 -3
==========================================
- Hits 1028 1025 -3
Misses 68 68
Continue to review full report at Codecov.
|
Rename BaseResource's build_filter and list as get_filters and get_list respectively (the latter being now a method instead of a property). get_list now accepts optional filters (get_filters is used if none provided).