Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

Check for validity of conversation object was done on approval, but not on fail, inquire nor skip.

@codecov-io
Copy link

Codecov Report

Merging #47 into master will increase coverage by 0.6%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #47     +/-   ##
=========================================
+ Coverage   90.93%   91.53%   +0.6%     
=========================================
  Files          31       31             
  Lines        1412     1406      -6     
=========================================
+ Hits         1284     1287      +3     
+ Misses        128      119      -9
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 40.29% <16.66%> (+6.51%) ⬆️
connect/resources/base.py 92.85% <0%> (ø) ⬆️
connect/models/fulfillment.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7869c0c...b5e8627. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 31, 2019

Codecov Report

Merging #47 into master will increase coverage by 0.6%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #47     +/-   ##
=========================================
+ Coverage   90.93%   91.53%   +0.6%     
=========================================
  Files          31       31             
  Lines        1412     1406      -6     
=========================================
+ Hits         1284     1287      +3     
+ Misses        128      119      -9
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 40.29% <16.66%> (+6.51%) ⬆️
connect/resources/base.py 92.85% <0%> (ø) ⬆️
connect/models/fulfillment.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7869c0c...b5e8627. Read the comment docs.

@vgrebenschikov vgrebenschikov merged commit 0c8b8e3 into cloudblue:master May 31, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-25-fix-conversations branch May 31, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants