Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

If something bad happens while processing a request, the exception will be caught by the dispatcher so the program does not crash and the request is simply skipped.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #53 into master will decrease coverage by 0.5%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    91.6%   91.09%   -0.51%     
==========================================
  Files          31       31              
  Lines        1405     1415      +10     
==========================================
+ Hits         1287     1289       +2     
- Misses        118      126       +8
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 37.5% <0%> (-2.8%) ⬇️
connect/resources/tier_config_automation.py 90.47% <40%> (-6.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9031ba...2dccd38. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #53 into master will decrease coverage by 0.5%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage    91.6%   91.09%   -0.51%     
==========================================
  Files          31       31              
  Lines        1405     1415      +10     
==========================================
+ Hits         1287     1289       +2     
- Misses        118      126       +8
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 37.5% <0%> (-2.8%) ⬇️
connect/resources/tier_config_automation.py 90.47% <40%> (-6.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9031ba...2dccd38. Read the comment docs.

@vgrebenschikov vgrebenschikov merged commit 87d3bef into cloudblue:master Jun 18, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-28-dispatch-exceptions branch June 18, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants