Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

The configuration.product.id and configuration.account.id filters do not work as expected. Reverting to configuration__product__id and configuration__account__id.

…not work as expected. Reverting to configuration__product__id and configuration__account__id.
@codecov-io
Copy link

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #54   +/-   ##
======================================
  Coverage    91.6%   91.6%           
======================================
  Files          31      31           
  Lines        1405    1405           
======================================
  Hits         1287    1287           
  Misses        118     118
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 40.29% <ø> (ø) ⬆️
connect/models/tier_config.py 89.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9031ba...30a6ff6. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #54   +/-   ##
======================================
  Coverage    91.6%   91.6%           
======================================
  Files          31      31           
  Lines        1405    1405           
======================================
  Hits         1287    1287           
  Misses        118     118
Impacted Files Coverage Δ
connect/resources/fulfillment_automation.py 40.29% <ø> (ø) ⬆️
connect/models/tier_config.py 89.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9031ba...30a6ff6. Read the comment docs.

Copy link
Contributor

@marcserrat marcserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only requests api works with ., tier is with _
please keep this things with PHP sdk ;)

@marcserrat marcserrat self-requested a review June 17, 2019 13:36
@JaviCerveraIngram
Copy link
Collaborator Author

Ok, I changed it back in the day due to this discussion on another PR.

@vgrebenschikov vgrebenschikov merged commit 9b84203 into cloudblue:master Jun 18, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-8-get-tier-config branch June 18, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants