Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

No description provided.

Added FulfillmentAutomation.create_request()
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #64 into master will decrease coverage by 0.16%.
The diff coverage is 92.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   90.95%   90.79%   -0.17%     
==========================================
  Files          31       31              
  Lines        1438     1542     +104     
==========================================
+ Hits         1308     1400      +92     
- Misses        130      142      +12
Impacted Files Coverage Δ
connect/models/__init__.py 100% <100%> (ø) ⬆️
connect/models/event.py 100% <100%> (ø) ⬆️
connect/models/tier_config.py 91.46% <100%> (+1.75%) ⬆️
connect/models/usage.py 100% <100%> (ø) ⬆️
connect/models/parameters.py 100% <100%> (ø) ⬆️
connect/models/product.py 100% <100%> (ø) ⬆️
connect/resources/fulfillment_automation.py 37.33% <33.33%> (-0.17%) ⬇️
connect/models/schemas.py 90.47% <88.63%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5034f88...b05be68. Read the comment docs.

@marcserrat marcserrat self-requested a review September 5, 2019 09:02
period = None # type: str
""" (str) Period. """

type = None # type: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is python function ... but looks like more or less safe to use it here

@vgrebenschikov vgrebenschikov merged commit f0dbe52 into cloudblue:master Sep 13, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-37-models branch September 16, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants