Skip to content

Conversation

@JaviCerveraIngram
Copy link
Collaborator

Put each model in its own Python file, to reduce the chance of having circular references on imports.

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #66 into master will increase coverage by 0.75%.
The diff coverage is 99.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   92.05%   92.81%   +0.75%     
==========================================
  Files          32       65      +33     
  Lines        1574     1739     +165     
==========================================
+ Hits         1449     1614     +165     
  Misses        125      125
Impacted Files Coverage Δ
connect/models/activation_tile_response.py 100% <ø> (ø)
connect/models/product_stats.py 100% <100%> (ø)
connect/models/agreement.py 100% <100%> (ø)
connect/models/param.py 100% <100%> (ø)
connect/models/event.py 100% <100%> (ø) ⬆️
connect/models/product_stats_info.py 100% <100%> (ø)
connect/models/schemas.py 92.64% <100%> (ø) ⬆️
connect/models/customer_ui_settings.py 100% <100%> (ø)
connect/models/configuration.py 100% <100%> (ø)
connect/models/ext_id_hub.py 100% <100%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbaf3e5...ee04ace. Read the comment docs.

@vgrebenschikov vgrebenschikov merged commit 7fab284 into cloudblue:master Sep 24, 2019
@JaviCerveraIngram JaviCerveraIngram deleted the CPS-46-refactor-models branch September 25, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants