Cps 43 logger improvements #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cps 43 logger improvements
ht-albert
suggested changes
Sep 26, 2019
| sformat = request.id + " " + request.contract.marketplace.id + base | ||
| [handler.setFormatter(logging.Formatter(sformat, "%I:%M:%S")) | ||
| for handler in self.__class__.logger.handlers] | ||
|
|
Contributor
There was a problem hiding this comment.
Mb use the default setting for logger
Right now we use thrice this block. Only field sformat different
handlers = [copy.copy(hdlr) for hdlr in global_logger.handlers]
log_level = global_logger.level
self.__class__.logger.propagate = False
self.__class__.logger.setLevel(log_level)
[self.__class__.logger.addHandler(hdlr) for hdlr in handlers]
base = " %(levelname)-6s; %(asctime)s; %(name)-6s; %(module)s:%(funcName)s:line" \
"-%(lineno)d: %(message)s"
sformat = request.id + " " + request.contract.marketplace.id + base
[handler.setFormatter(logging.Formatter(sformat, "%I:%M:%S"))
for handler in self.__class__.logger.handlers]
Contributor
There was a problem hiding this comment.
Javi what you think about that suggestion?
Collaborator
Author
There was a problem hiding this comment.
Hasn't that been fixed in the commits made afterwards?
Cps 43 logger improvements
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
- Coverage 92.78% 92.7% -0.08%
=========================================
Files 67 67
Lines 1872 1893 +21
=========================================
+ Hits 1737 1755 +18
- Misses 135 138 +3
Continue to review full report at Codecov.
|
ht-albert
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom loggers to the automation classes, that automatically add relevant info of the request being processed. Legacy global logger still working in order to have a context-independent logger.